Skip to content

Filters in Artifact download planner #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rugvedS07 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Filters in Artifact download planner #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a69670
Allow filters in artifact download planner
rugvedS07 Sep 12, 2025
345d348
Add lms-cli commit
rugvedS07 Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/lms-cli
Open in desktop
Submodule lms-cli updated 1 files
+46 −10 src/subcommands/get.ts
23 changes: 15 additions & 8 deletions packages/lms-client/src/repository/RepositoryNamespace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import {
import { type RepositoryPort } from "@lmstudio/lms-external-backend-interfaces";
import {
jsonSerializableSchema,
type ModelCompatibilityType,
modelCompatibilityTypeSchema,
modelSearchOptsSchema,
type ArtifactDownloadPlan,
type DownloadProgressUpdate,
Expand Down Expand Up @@ -130,11 +132,15 @@ export const loginWithPreAuthenticatedKeysResultSchema = z.object({
export interface CreateArtifactDownloadPlannerOpts {
owner: string;
name: string;
compatibilityTypeFilter?: ModelCompatibilityType[];
quantizationFilter?: string[];
onPlanUpdated?: (plan: ArtifactDownloadPlan) => void;
}
export const createArtifactDownloadPlannerOptsSchema = z.object({
owner: z.string(),
name: z.string(),
compatibilityTypeFilter: z.array(modelCompatibilityTypeSchema).optional(),
quantizationFilter: z.array(z.string()).optional(),
onPlanUpdated: z.function().optional(),
}) as ZodSchema<CreateArtifactDownloadPlannerOpts>;

Expand Down Expand Up @@ -396,17 +402,18 @@ export class RepositoryNamespace {
public createArtifactDownloadPlanner(
opts: CreateArtifactDownloadPlannerOpts,
): ArtifactDownloadPlanner {
const { owner, name, onPlanUpdated } = this.validator.validateMethodParamOrThrow(
"repository",
"createArtifactDownloadPlanner",
"opts",
createArtifactDownloadPlannerOptsSchema,
opts,
);
const { owner, name, onPlanUpdated, compatibilityTypeFilter, quantizationFilter } =
this.validator.validateMethodParamOrThrow(
"repository",
"createArtifactDownloadPlanner",
"opts",
createArtifactDownloadPlannerOptsSchema,
opts,
);
const stack = getCurrentStack(1);
const channel = this.repositoryPort.createChannel(
"createArtifactDownloadPlan",
{ owner, name },
{ owner, name, compatibilityTypeFilter, quantizationFilter },
undefined, // Don't listen to the messages yet.
{ stack },
);
Expand Down
3 changes: 3 additions & 0 deletions packages/lms-external-backend-interfaces/src/repositoryBackendInterface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
modelSearchResultEntryDataSchema,
modelSearchResultIdentifierSchema,
hubModelSchema,
modelCompatibilityTypeSchema,
} from "@lmstudio/lms-shared-types";
import { z } from "zod";

Expand Down Expand Up @@ -158,6 +159,8 @@ export function createRepositoryBackendInterface() {
creationParameter: z.object({
owner: kebabCaseSchema,
name: kebabCaseWithDotsSchema,
compatibilityTypeFilter: modelCompatibilityTypeSchema.array().optional(),
quantizationFilter: z.string().array().optional(),
}),
toServerPacket: z.discriminatedUnion("type", [
/**
Expand Down