ansititle: add windows support #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixed the code formatting |
|
|
Nice PR! What happens if someone is using something other than Windows Terminal on Windows? |
|
it doesn't do anything since most other custom terminals don't work with the windows api, i could probably try to come up with a fix if you want though |
|
If it doesn't crash the host, then that might be good enough in that the unhappy path would be no different from the current code you're improving upon. Do you know if there is a reliable way to check if the term is a Windows Terminal instance? |
|
no i don't know, it doesn't crash the host though that's for sure |
|
Awesome. Great work on this PR! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting the titlebar-func in the shell config now works on windows
2025-07-23.20-12-40.mp4