azure auth

[skull8888888]

Important

Add Azure authentication support with a new button component and feature flag control.

• Azure Authentication:
  • Adds AzureButton component in azure-button.tsx for Azure authentication.
  • Integrates Azure authentication in sign-in.tsx and sign-up.tsx with enableAzure prop.
  • Updates SignInPage and SignUpPage to enable Azure auth if AZURE_AUTH feature is enabled.
• Feature Management:
  • Adds AZURE_AUTH to Feature enum in features.ts.
  • Updates isFeatureEnabled to check Azure auth environment variables.
• Auth Providers:
  • Adds Azure AD provider in auth.ts using next-auth/providers/azure-ad.

^{This description was created by for b01a7cb. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Caution

Changes requested ❌

Reviewed everything up to 0ee0734 in 1 minute and 46 seconds. Click for details.

• Reviewed 263 lines of code in 7 files
• Skipped 0 files when reviewing.
• Skipped posting 2 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. frontend/app/sign-in/page.tsx:14

• Draft comment:
  Empty catch block. Consider logging or handling the caught error.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. frontend/app/sign-up/page.tsx:14

• Draft comment:
  Empty catch block. Consider logging or handling the caught error.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_szTR6AGia8cTw83x

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[ellipsis-dev]

The 'callbackUrl' prop is defined and destructured but not used in rendering. Consider removing it from the props to avoid confusion.

[dinmukhamedm]

LGTM. Ellipsis nit seems correct

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed b01a7cb in 1 minute and 33 seconds. Click for details.

• Reviewed 157 lines of code in 6 files
• Skipped 1 files when reviewing.
• Skipped posting 7 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. frontend/components/auth/azure-button.tsx:10

• Draft comment:
  Removed callbackUrl from AzureButtonProps; ensure it's no longer needed.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

2. frontend/components/auth/azure-button.tsx:29

• Draft comment:
  Adjusted padding (pr-6) and margin (ml-2); verify UI consistency with other auth buttons.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify UI consistency, which falls under the rule of not asking the author to double-check things. It doesn't provide a specific suggestion or point out a clear issue.

3. frontend/components/auth/github-button.tsx:8

• Draft comment:
  Removed callbackUrl from GitHubButtonProps; ensure callback handling is managed elsewhere.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

4. frontend/components/auth/google-button.tsx:12

• Draft comment:
  Removed callbackUrl from GoogleButtonProps; confirm callback is handled via signIn.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

5. frontend/components/auth/sign-in.tsx:57

• Draft comment:
  Removed callbackUrl prop from third‐party button instances; callbackUrl is now provided via signIn.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

6. frontend/components/auth/sign-up.tsx:55

• Draft comment:
  Removed callbackUrl prop from auth button calls; verify the auth flow remains consistent.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

7. frontend/lib/features/features.ts:53

• Draft comment:
  Added SEND_EMAIL feature flag check; ensure RESEND_API_KEY is correctly configured in the environment.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to ensure that a specific environment variable is correctly configured. This falls under the rule of not asking the author to ensure something is tested or configured correctly. Therefore, this comment should be removed.

Workflow ID: wflow_UAEzBN4nBlPC6wDy

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}