Skip to content

add an alias for ai sdk v4 tool args; update tests to catch #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2025
Merged

add an alias for ai sdk v4 tool args; update tests to catch #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34786ce
add an alias for ai sdk v4 tool args; update tests to catch
dinmukhamedm Aug 22, 2025
3a0dda7
fix test
dinmukhamedm Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app-server/src/language_model/chat_message.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ pub struct InstrumentationChatMessageDocument {
pub struct InstrumentationChatMessageAISDKToolCall {
pub tool_name: String,
pub tool_call_id: Option<String>,
#[serde(alias = "args")] // In AI SDK v4 it used to be called "args"
pub input: Option<serde_json::Value>,
}

Expand Down
39 changes: 22 additions & 17 deletions app-server/src/traces/spans.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2564,7 +2564,8 @@ mod tests {
let parent_span_id = Uuid::new_v4();
let child_span_id = Uuid::new_v4();
let trace_id = Uuid::new_v4();
let key = if is_v4 { "result" } else { "output" };
let output_key = if is_v4 { "result" } else { "output" };
let input_key = if is_v4 { "args" } else { "input" };

// Create parent span (ai.generateText) - has DEFAULT span type
let parent_attributes = HashMap::from([
Expand All @@ -2581,12 +2582,12 @@ mod tests {
"messages":[
{"role":"user","content":"What is the weather and time in SF?"},
{"role":"assistant","content":[
{"type":"tool-call","toolCallId":"call_9oYyi7pB9xSW5ceOmcWnERiS","toolName":"get_weather","args":{"location":"San Francisco, CA"}},
{"type":"tool-call","toolCallId":"call_K9NDZ4DGgxbiy4HIL5IDNjiS","toolName":"get_time","args":{"location":"San Francisco, CA"}}
{"type":"tool-call","toolCallId":"call_9oYyi7pB9xSW5ceOmcWnERiS","toolName":"get_weather",input_key:{"location":"San Francisco, CA"}},
{"type":"tool-call","toolCallId":"call_K9NDZ4DGgxbiy4HIL5IDNjiS","toolName":"get_time",input_key:{"location":"San Francisco, CA"}}
]},
{"role":"tool","content":[
{"type":"tool-result","toolCallId":"call_9oYyi7pB9xSW5ceOmcWnERiS","toolName":"get_weather",key:"Sunny as always!"},
{"type":"tool-result","toolCallId":"call_K9NDZ4DGgxbiy4HIL5IDNjiS","toolName":"get_time",key:"12:00 PM"}
{"type":"tool-result","toolCallId":"call_9oYyi7pB9xSW5ceOmcWnERiS","toolName":"get_weather",output_key:"Sunny as always!"},
{"type":"tool-result","toolCallId":"call_K9NDZ4DGgxbiy4HIL5IDNjiS","toolName":"get_time",output_key:"12:00 PM"}
]}
]
}).to_string(),
Expand Down Expand Up @@ -2666,12 +2667,12 @@ mod tests {
json!({"role":"system","content":"You are a helpful assistant."}),
json!({"role":"user","content":[{"type":"text","text":"What is the weather and time in SF?"}]}),
json!({"role":"assistant","content":[
{"type":"tool-call","toolCallId":"call_D2fRbvPAs1s4C9fd60l9diSk","toolName":"get_weather","args":{"location":"San Francisco, CA"}},
{"type":"tool-call","toolCallId":"call_mB9nVqiW5NlbtFtBi06Gzr5F","toolName":"get_time","args":{"location":"San Francisco, CA"}}
{"type":"tool-call","toolCallId":"call_D2fRbvPAs1s4C9fd60l9diSk","toolName":"get_weather",input_key:{"location":"San Francisco, CA"}},
{"type":"tool-call","toolCallId":"call_mB9nVqiW5NlbtFtBi06Gzr5F","toolName":"get_time",input_key:{"location":"San Francisco, CA"}}
]}),
json!({"role":"tool","content":[
{"type":"tool-result","toolCallId":"call_D2fRbvPAs1s4C9fd60l9diSk","toolName":"get_weather",key:"Sunny as always!"},
{"type":"tool-result","toolCallId":"call_mB9nVqiW5NlbtFtBi06Gzr5F","toolName":"get_time",key:"12:00 PM"}]})
{"type":"tool-result","toolCallId":"call_D2fRbvPAs1s4C9fd60l9diSk","toolName":"get_weather",output_key:"Sunny as always!"},
{"type":"tool-result","toolCallId":"call_mB9nVqiW5NlbtFtBi06Gzr5F","toolName":"get_time",output_key:"12:00 PM"}]})
])
.to_string()
),
Expand Down Expand Up @@ -2888,14 +2889,18 @@ mod tests {
_ => panic!("Expected content part list for assistant message"),
};
assert_eq!(assistant_message_content.len(), 2);
assert!(matches!(
assistant_message_content[0],
ChatMessageContentPart::ToolCall(_)
));
assert!(matches!(
assistant_message_content[1],
ChatMessageContentPart::ToolCall(_)
));

for part in assistant_message_content {
match part {
ChatMessageContentPart::ToolCall(tool_call) => {
assert_eq!(
tool_call.arguments,
Some(json!({"location":"San Francisco, CA"}))
);
}
_ => panic!("Expected tool call for assistant message"),
}
}

let tool_message = &child_input_messages[3];
let tool_message_content = match &tool_message.content {
Expand Down