Create docker file #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`python3 build.cgi` Addresses issue lmcnulty#3.
Seek assignment was reversed. This fixes it to: ``` mediaElement.currentTime = current.playbackTime ``` This restores the user's ability to seek to a specific point in the audio file. Resolves lmcnulty#5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to resolve #7, introduce a docker file that will make it easy to start running
There are two dockerfiles, the base
Dockerfileand theDockerfileDev, which is intended to use the base and the execute the website from the/mnt/gvvdirectory which is mounted from the actual directory. This will allow faster development by not needing the docker image to be recreated.The current implementation is incomplete as there are some weirdnesses getting conda to work correctly, but I think this will make it easier to run tests and set up the dev environment for contributors.