Fix torch.bool parsed as signless i1
#752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathyzhyi
requested changes
Apr 13, 2022
lib/Dialect/Torch/Utils/Utils.cpp
Outdated
| @@ -50,7 +50,7 @@ torch_upstream::ScalarType Torch::getScalarTypeForType(Type type) { | |||
| return torch_upstream::ScalarType::Long; | |||
| if (type.isSignedInteger(32)) | |||
| return torch_upstream::ScalarType::Int; | |||
| if (type.isUnsignedInteger(1)) | |||
| if (type.isUnsignedInteger(1) || type.isSignlessInteger(1)) | |||
There was a problem hiding this comment.
Actually, the type.isUnsignedInteger(1) can be removed as the dtype can't be si1
torch-mlir/include/torch-mlir/Dialect/Torch/IR/TorchTypes.td
Lines 155 to 167 in eaf34fa
|
btw, the new test need to be added to the list here |
makslevental
force-pushed
the
fix_signless_bool
branch
from
c4901d3 to
a4fe4fd
Compare
cathyzhyi
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #751 where
torch.boolis parsed as signlessi1.