Fix misuse of normalize_function api
#740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
force-pushed
the
fix_normalize_function
branch
from
33582ed to
20b2cb2
Compare
makslevental
force-pushed
the
fix_normalize_function
branch
2 times, most recently
from
544e011 to
956ec9d
Compare
silvasean
suggested changes
Apr 7, 2022
…_args_kwargs` (in eager mode) and introduces unit tests. NB: `shouldnt_normalize2` and `shouldnt_normalize3` currently XPASS i.e., args *will* successfully normalize despite being incorrect due to an [upstream bug](pytorch/pytorch#75342).
makslevental
force-pushed
the
fix_normalize_function
branch
from
956ec9d to
c3cee59
Compare
This was referenced Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in use of upstream
normalize_functionin ournormalize_args_kwargs(in eager mode) and introduces unit tests.NB:
shouldnt_normalizecurrently fails i.e., args will successfully normalize despite being incorrect due to an upstream bug.