Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Rename external -> externals #699

Merged
merged 1 commit into from
Mar 26, 2022
Merged

[NFC] Rename external -> externals #699

merged 1 commit into from
Mar 26, 2022

Conversation

asaadaldien
Copy link
Member

@asaadaldien asaadaldien commented Mar 24, 2022 •
edited
Loading

This resolves issues with bazel top level external directory.

Towards fixing #14

@asaadaldien asaadaldien marked this pull request as ready for review March 24, 2022 22:52
@asaadaldien asaadaldien requested a review from silvasean March 24, 2022 22:52
@asaadaldien asaadaldien mentioned this pull request Mar 24, 2022
Closed
@silvasean
Copy link
Contributor

Can you squash the commits and link to the bug from the commit message?

@asaadaldien
Copy link
Member Author

@silvasean done, PTAL. thanks!

silvasean
silvasean approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@silvasean silvasean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you also link to the Torch-MLIR bug as well from the PR description?

Also, do we need any special git flags when syncing past this PR?

@asaadaldien
Copy link
Member Author

asaadaldien commented Mar 25, 2022 •
edited
Loading

nit: can you also link to the Torch-MLIR bug as well from the PR description?

Also, do we need any special git flags when syncing past this PR?

Not git but cmake, should I update README in this PR ? to do:

cmake -GNinja -Bbuild \
  -DCMAKE_C_COMPILER=clang \
  -DCMAKE_CXX_COMPILER=clang++ \
  -DPython3_FIND_VIRTUALENV=ONLY \
  -DLLVM_ENABLE_PROJECTS=mlir \
  -DLLVM_EXTERNAL_PROJECTS="torch-mlir;torch-mlir-dialects" \
  -DLLVM_EXTERNAL_TORCH_MLIR_SOURCE_DIR=`pwd` \
  -DLLVM_EXTERNAL_TORCH_MLIR_DIALECTS_SOURCE_DIR=`pwd`/externals/llvm-external-projects/torch-mlir-dialects \
  -DMLIR_ENABLE_BINDINGS_PYTHON=ON \
  -DLLVM_TARGETS_TO_BUILD=host \
  externals/llvm-project/llvm

@silvasean
Copy link
Contributor

Yes, please update everything in the repo that references the old name atomically in this PR.

You should have push ability on the repo, so feel free to push when you are satisfied.

@asaadaldien asaadaldien merged commit 8383497 into llvm:main Mar 26, 2022
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
@AlexandreEichenberger
Added return of nonzero value when errors occur (llvm#699)
68b24d2 
* added return of nonzero value when errors occur

Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>

* update

Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>

* removed the wrong one, fixed

Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvasean silvasean silvasean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asaadaldien @silvasean