[TORCH][MLIR] Fix the return types of aten.native_layer_norm.
#674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gprateek93
force-pushed
the
prateek/fix-aten-native-layer-norm
branch
from
eedecc0 to
3ed910c
Compare
cathyzhyi
approved these changes
Mar 16, 2022
python/torch_mlir/dialects/torch/importer/jit_ir/build_tools/shape_lib_gen.py
Show resolved
Hide resolved
ramiro050
reviewed
Mar 16, 2022
This commit fixes the 2nd and 3rd return types of the `aten.native_layer_norm`. Previously the mean and rSTD were returned with reduction dims removed. This commit fixes this and keeps the reduction dims of the results. Signed-Off-By: Prateek Gupta <prateek@nord-labs.com>
gprateek93
force-pushed
the
prateek/fix-aten-native-layer-norm
branch
from
3ed910c to
9a46f7c
Compare
|
Thanks for the quick follow-up! |
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
* Various small fixes Some typos; some white space; removing duplicate lib in OMLibs; removing a couple of unused include directories; removing unused definition INCLUDE_ONNX_ML; moving a dependency to the correct cmake; removing add_c_unit_test function which is only used in one place; making debug.py work (better) on windows Signed-off-by: Stella Stamenova <stilis@microsoft.com> * Run clang-format Signed-off-by: Stella Stamenova <stilis@microsoft.com> Co-authored-by: Kevin O'Brien <caomhin@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the 2nd and 3rd return types of the
aten.native_layer_norm.Previously the mean and rSTD were returned with reduction dims removed.
This commit fixes this and keeps the reduction dims of the results.
Signed-Off-By: Prateek Gupta prateek@nord-labs.com
fixes: #665