[MLIR][TORCH] Add E2E support for max_pool2d_with_indices op #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramiro050
requested changes
Jan 11, 2022
vivekkhandelwal1
force-pushed
the
aten-maxpool2d-with-indices
branch
from
23674a7 to
971f70e
Compare
|
I have not rebased it over the latest upstream changes because the newest commit creates a linker error. |
ramiro050
requested changes
Jan 12, 2022
e2e_testing/torchscript/basic.py
Outdated
| @export | ||
| @annotate_args([ | ||
| None, | ||
| ([-1, -1, -1, -1], torch.float32, True), |
There was a problem hiding this comment.
I think it would be nice to also have a test for the 3d input case, to make sure it is also being handled correctly
There was a problem hiding this comment.
I don't think the current implementation of maxpool2d supports 3-d cases at present.
vivekkhandelwal1
force-pushed
the
aten-maxpool2d-with-indices
branch
from
971f70e to
51d6140
Compare
|
Please don't re-review the code as of now. I have just resolved the conflicts, working on fixing the issues. |
vivekkhandelwal1
force-pushed
the
aten-maxpool2d-with-indices
branch
from
51d6140 to
22d1ef6
Compare
|
@ramiro050 @cathyzhyi I have updated the code. Please review this when you find the time. |
pashu123
requested changes
Apr 5, 2022
cathyzhyi
requested changes
Apr 5, 2022
ramiro050
requested changes
Apr 7, 2022
vivekkhandelwal1
force-pushed
the
aten-maxpool2d-with-indices
branch
from
22d1ef6 to
62fe70a
Compare
|
@cathyzhyi @ramiro050 Just a gentle reminder for your review. |
vivekkhandelwal1
force-pushed
the
aten-maxpool2d-with-indices
branch
from
62fe70a to
5ea706a
Compare
cathyzhyi
requested changes
Apr 14, 2022
This commit adds lowering of `max_pool2d_with_indices` op. Signed-Off By: Vivek Khandelwal <vivek@nod-labs.com>
vivekkhandelwal1
force-pushed
the
aten-maxpool2d-with-indices
branch
from
5ea706a to
9238d2b
Compare
cathyzhyi
approved these changes
Apr 18, 2022
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
Co-authored-by: Kevin O'Brien <caomhin@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds lowering of
max_pool2d_with_indicesop.Signed-Off By: Vivek Khandelwal vivek@nod-labs.com