fix: break circular dependency to enable 'BUILD_SHARED_LIBS'#4620
Open
jackfiled wants to merge 1 commit into
Open
fix: break circular dependency to enable 'BUILD_SHARED_LIBS'#4620jackfiled wants to merge 1 commit into
jackfiled wants to merge 1 commit into
Conversation
Break the circular dependcy in TorchMLIRTorchDialect and TorchMLIRTorchUtils, TorchMLIRConversionPasses and TorchMLIRTorchConversionPasses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to close #3961.
Torch-MLIRfails to build when using-DBUILD_SHARED_LIBS=ON. The root cause is a circular dependency betweenTorchMLIRTorchUtilsandTorchMLIRTorchDialect, betweenTorchMLIRConversionPassesandTorchMLIRTorchConversionPasses, combined with many missing explicit link dependencies across conversion libraries.This commit does the following works:
TorchMLIRTorchDialectand movesqueezeTensor/unsqueezeTensor/sparsityfunctions toTorchOps.cppto makeTorchMLIRTorchDialectnot depend onTorchMLIRTorchUtils.TorchMLIRConversionPassesandTorchMLIRTorchConversionPasses.LINK_LIBS.It's my first time to contribute to LLVM community and this project, any feedback is appreciated!