DecomposeAtenAminAmaxOp negative axis fix#4556
Open
voonter wants to merge 1 commit into
Open
Conversation
voonter
force-pushed
the
fix-decompatenaminamaxop-negative-axis
branch
from
37a5bb3 to
f4679a0
Compare
zjgarvey
approved these changes
May 15, 2026
zjgarvey
left a comment
zjgarvey
left a comment
Collaborator
There was a problem hiding this comment.
Can you explain what the issue was a bit more? E.g., is it that the sorting needs to happen after making the dims positive? If so, LGTM
Author
Yes. Reducing from the last axis only works when the axes are sorted as positive values. Negative axes break that ordering. And with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4553
Fixed support for negative axis in DecomposeAtenAminAmaxOp