[MLIR][TORCH] Add E2E support for aten.squeeze op
#441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathyzhyi
requested changes
Nov 24, 2021
Shukla-Gaurav
force-pushed
the
gaurav/lower_squeeze
branch
2 times, most recently
from
1c2c2dd to
8b20c40
Compare
cathyzhyi
reviewed
Nov 29, 2021
Shukla-Gaurav
force-pushed
the
gaurav/lower_squeeze
branch
3 times, most recently
from
5779b4a to
d408934
Compare
This commit adds lowering of `aten.Squeeze` op into `linalg.TensorCollapseShape` op. The size 1 dynamic dimensions are not handled as a part of this commit. Signed-Off-by: Gaurav Shukla <gaurav@nod-labs.com>
Shukla-Gaurav
force-pushed
the
gaurav/lower_squeeze
branch
from
d408934 to
d508078
Compare
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
…ry pools (llvm#441) * Reorganize main function. * Follow review comments. * Emit constants are globals in Krnl and LLVM dialects. * Remove mutex. Use pass-local variable for map. * Format. Co-authored-by: Alexandre Eichenberger <alexe@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds lowering of
aten.Squeezeop intolinalg.TensorCollapseShapeop. The size 1 dynamic dimensions are nothandled as a part of this commit.
Signed-Off-by: Gaurav Shukla gaurav@nod-labs.com