Add a new python script to auto-generate ATen op ODS definitions. #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
stellaraccident
commented
Sep 16, 2020
stellaraccident
commented
- There is still some work on some of the ops to annotate correct types.
- The ODS is not actually included into the dialect yet, but I'd like to commit it so that we can track changes.
- Will reconcile this with the ops produced by the existing script in a followup. I can either attempt to do that in one step or simply include these into the dialect for now and transition all of it over the course of several commits (they do not have colliding names). I'm leaning towards the latter.
* There is still some work on some of the ops to annotate correct types. * The ODS is not actually included into the dialect yet, but I'd like to commit it so that we can track changes. * Will reconcile this with the ops produced by the existing script in a followup. I can either attempt to do that in one step or simply include these into the dialect for now and transition all of it over the course of several commits (they do not have colliding names). I'm leaning towards the latter.
silvasean
approved these changes
Sep 16, 2020
| ATenAnyRefTensor:$out | ||
| ); | ||
| let results = (outs | ||
| ATenAnyRefTensor:$result |
There was a problem hiding this comment.
is it intentional that this returns a ref? I would expect either an out param or a result, but not both.
There was a problem hiding this comment.
Good catch, thanks. The Python API does indeed return the out ref but there is no reason for these ops to be structured that way.
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
Re-enable Reciprocal tests.
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
* Fix a bug in createArrayAttribute * Use size_t * Use const auto&
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.