[torch] Update torch.bmm to use accumulator type
#3924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Batch matmul was using the result type as the accumulator. Updated to use the preferred accumulator based on input type.
|
Do we need a test? |
There should be an existing testing. Getting the |
MaheshRavishankar
approved these changes
Dec 19, 2024
rahuls-cerebras
added a commit
that referenced
this pull request
Jan 3, 2025
This reverts commit 061bbc5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch matmul was using the result type as the accumulator. Updated to use the preferred accumulator based on input type.