Skip to content

Add attributes support for onnx.nms #3920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Add attributes support for onnx.nms #3920

merged 2 commits into from
Dec 19, 2024

Conversation

jinchen62
Copy link
Collaborator

  • Set default attribute values
  • Support max_output_boxes_per_class attribute
  • e2e test test_nonmaxsuppression_limit_output_size passed

@jinchen62 jinchen62 force-pushed the nms branch 2 times, most recently from 7855ce2 to a5fee36 Compare December 17, 2024 16:52
Copy link
Collaborator

@AmosLewis AmosLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinchen62 jinchen62 merged commit e68560d into llvm:main Dec 19, 2024
3 checks passed
@jinchen62 jinchen62 deleted the nms branch December 19, 2024 03:42
rahuls-cerebras added a commit that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants