Skip to content

[onnx][importer] Merge character sanitization into regex #3914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2024
Merged

[onnx][importer] Merge character sanitization into regex #3914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions python/torch_mlir/extras/onnx_importer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,13 +740,9 @@ def _sanitize_name(self, name):
if not name.isidentifier():
name = "_" + name

# The presence of '-' characters in the initializer names can cause
# unintended side-effects when the IR is parsed during compilation.
# Simply replace all the occurrences of '-' in the name string when the
# dense resource is created.
name = name.replace("-", "_")

return re.sub("[:/]", "_", name)
# Remove characters that are invalid in MLIR identifier names.
# https://mlir.llvm.org/docs/LangRef/#identifiers-and-keywords
return re.sub("[:/-]", "_", name)

def tensor_proto_to_attr(self, tp: onnx.TensorProto) -> Attribute:
tensor_type = self.tensor_proto_to_builtin_type(tp)
Expand Down
Loading