Only unroll prim loop-like ops within a torch.shape.calculate region
#3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zjgarvey, I'm merging this patch since it's needed for the Torch-MLIR bump in IREE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reports a match failure for the pattern
FullyUnrollPrimLoopwhen the loop op is not in a region defined by atorch.shape.calculateop.This is needed to avoid unrolling prim loops generated by ONNX IR, since we are applying shape refinement in the
torch-onnx-to-torch-backend-pipelineintroduced in fa4794d .See also the discussion in iree-org/iree#18867 (comment)