Skip to content

[Torch Dialect] Allow simplification of shape calculations of aten.tile, col2im, aten.stft #3785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 14, 2024
Merged

[Torch Dialect] Allow simplification of shape calculations of aten.tile, col2im, aten.stft #3785

merged 7 commits into from
Nov 14, 2024

Conversation

giacs-epic
Copy link
Contributor

  • Add aten.mul.left_t (+ canonicalizer) to allow simplification of aten.tile.
  • Change syntax of the computation of col2im shape to allow the use of an already existing canonicalization pattern (for aten.add.t) for its simplification.
  • Add aten.eq.bool ( + folder) to allow simplification of aten.stft.

zjgarvey
zjgarvey requested changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A small change and I think this is good to go.

@zjgarvey zjgarvey self-requested a review November 12, 2024 19:09
zjgarvey
zjgarvey approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nitpick if you think it would look better. If you like the folder as-is, I don't have any complaints and we can merge as-is.

@zjgarvey
Copy link
Collaborator

Might also need to re-run the build_tools/update_abstract_interp_lib.sh

zjgarvey
zjgarvey approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjgarvey zjgarvey merged commit 06d1789 into llvm:main Nov 14, 2024
3 checks passed
rahuls-cerebras added a commit that referenced this pull request Jan 3, 2025
@rahuls-cerebras
Revert "[Torch Dialect] Allow simplification of shape calculations of…
1d3c7c6 
… aten.tile, col2im, aten.stft (#3785)"

This reverts commit 06d1789.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjgarvey zjgarvey zjgarvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giacs-epic @zjgarvey