[Torch Dialect] Allow simplification of shape calculations of aten.tile, col2im, aten.stft #3785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjgarvey
requested changes
Nov 8, 2024
zjgarvey
approved these changes
Nov 12, 2024
Comment on lines
+762
to
+767
| bool a, b; | ||
| if (!matchPattern(getOperand(0), m_TorchConstantBool(&a))) | ||
| return nullptr; | ||
| if (!matchPattern(getOperand(1), m_TorchConstantBool(&b))) | ||
| return nullptr; | ||
| return IntegerAttr::get(IntegerType::get(getContext(), 1), a == b); |
There was a problem hiding this comment.
This might be a bit of a nitpick, but we should be able to use the adaptor here instead of matching against constants.
E.g., something like:
auto aIntAttr = dyn_cast_or_null<IntegerAttr>(adaptor.getA());
auto bIntAttr = dyn_cast_or_null<IntegerAttr>(adaptor.getB());
if (!aIntAttr || !bIntAttr)
return nullptr;
return IntegerAttr::get(IntegerType::get(getContext(), 1), aIntAttr.getValue() == bIntAttr.getValue());
|
Might also need to re-run the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aten.mul.left_t(+ canonicalizer) to allow simplification of aten.tile.aten.add.t) for its simplification.aten.eq.bool( + folder) to allow simplification of aten.stft.