Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLIR][TORCH] Add support for 1-d group convolution #3770

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

vivekkhandelwal1
Copy link
Collaborator

This commit adds the support for the 1-d depthwise convolution as a special case of 1-d group convolution.

Signed-Off By: Vivek Khandelwal vivekkhandelwal1424@gmail.com

This commit adds the support for the 1-d depthwise convolution as a
special case of 1-d group convolution.

Signed-Off By: Vivek Khandelwal <vivekkhandelwal1424@gmail.com>
Copy link
Collaborator

@kumardeepakamd kumardeepakamd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is covering only the case that can be depthwise 1d conv, and using preexisting function. Good to go.

lib/Conversion/TorchToLinalg/Linear.cpp Show resolved Hide resolved
lib/Conversion/TorchToLinalg/Linear.cpp Show resolved Hide resolved
@vivekkhandelwal1 vivekkhandelwal1 merged commit 614fcdd into llvm:main Oct 8, 2024
3 checks passed
@vivekkhandelwal1 vivekkhandelwal1 deleted the fix-conv branch October 8, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants