Skip to content

[Torch Dialect] Add torch.aten.mul.int_float (required to simplify shape calculation of upsample_nearest2d) #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 20, 2024
Merged

[Torch Dialect] Add torch.aten.mul.int_float (required to simplify shape calculation of upsample_nearest2d) #3764

merged 7 commits into from
Nov 20, 2024

Conversation

giacs-epic
Copy link
Contributor

As per title. See also PR for torch.aten.mul.float_int.

zjgarvey
zjgarvey requested changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have a few comments, so please take a look and ping me when you'd like to have me re-review.

qingyunqu
qingyunqu approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@qingyunqu qingyunqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zjgarvey
zjgarvey reviewed Nov 18, 2024
View reviewed changes
zjgarvey
zjgarvey approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change to the lit test, otherwise lgtm

@giacs-epic @zjgarvey
Fix check in test/Conversion/TorchToArith/basic.mlir
7b89ddc 
Co-authored-by: zjgarvey <47986913+zjgarvey@users.noreply.github.com>
qingyunqu
qingyunqu reviewed Nov 20, 2024
View reviewed changes
@qingyunqu qingyunqu merged commit 1b8d7e0 into llvm:main Nov 20, 2024
3 checks passed
qingyunqu pushed a commit that referenced this pull request Nov 21, 2024
@giacs-epic @zjgarvey @qingyunqu
[Torch Dialect] Add torch.aten.mul.int_float (required to simplify …
ac4cb97 
…shape calculation of `upsample_nearest2d`) (#3764)

As per title. See also
[PR](#3750) for
`torch.aten.mul.float_int`.

---------

Co-authored-by: zjgarvey <47986913+zjgarvey@users.noreply.github.com>
rahuls-cerebras added a commit that referenced this pull request Jan 3, 2025
@rahuls-cerebras
Revert "[Torch Dialect] Add torch.aten.mul.int_float (required to s…
ec38cc9 
…implify shape calculation of `upsample_nearest2d`) (#3764)"

This reverts commit 1b8d7e0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingyunqu qingyunqu qingyunqu approved these changes

@zjgarvey zjgarvey zjgarvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giacs-epic @qingyunqu @zjgarvey