Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TorchToLinalg][test] Add test for ConvertAtenConvolutionOp #3679

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

CoTinker
Copy link
Contributor

This patch add a test for 638ef14, which use linalg.broadcast instead of generic for convolution bias.

@CoTinker CoTinker requested review from zjgarvey and ubfx August 30, 2024 09:09
@ubfx
Copy link
Member

ubfx commented Aug 30, 2024

I think this won't work because it depends on my PR so it will fail the pre-merge checks. But if you want, I can pull this commit into my PR, then it should pass.

Ah sorry, it depends on an already merged PR, I thought it was the other, unmerged one.

@CoTinker
Copy link
Contributor Author

I mean.

@CoTinker
Copy link
Contributor Author

Oh, Maybe my verison is too old. I'll fix it

This patch add a test for 638ef14, which use `linalg.broadcast`
instead of `generic` for convolution bias.
@CoTinker CoTinker enabled auto-merge (squash) August 30, 2024 09:51
@CoTinker CoTinker merged commit 3180704 into llvm:main Aug 30, 2024
3 checks passed
@CoTinker CoTinker disabled auto-merge August 30, 2024 09:51
@CoTinker
Copy link
Contributor Author

I accidentally clicked the enabled auto-merge, my fault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants