[TorchToLinalg] Fix possible OOB access in Interpolate lowering #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsuderman
approved these changes
Aug 2, 2024
pkapris-syrmia
pushed a commit
to pkapris-syrmia/torch-mlir
that referenced
this pull request
Aug 15, 2024
…#3570) Following up from the discussion in <llvm#3550>, I've edited the lowering to prevent OOB extracts in a more direct fashion (i.e., just clamping directly). I don't think this affects the lit tests at all, but I've tested the changes in our external test suite at <https://github.com/nod-ai/SHARK-TestSuite/tree/main/>. I found the issue when I was unexpectedly getting `nan`'s along the output image border for a resize test there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from the discussion in #3550, I've edited the lowering to prevent OOB extracts in a more direct fashion (i.e., just clamping directly).
I don't think this affects the lit tests at all, but I've tested the changes in our external test suite at https://github.com/nod-ai/SHARK-TestSuite/tree/main/. I found the issue when I was unexpectedly getting
nan's along the output image border for a resize test there.