Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Torch] enhance fold of aten.slice.Tensor #3557

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[Torch] enhance fold of aten.slice.Tensor #3557

merged 1 commit into from
Jul 23, 2024

Conversation

qingyunqu
Copy link
Collaborator

@qingyunqu qingyunqu commented Jul 23, 2024 •
edited
Loading

so that it could support folding slice with any static shape.

@qingyunqu qingyunqu requested review from rsuderman and Vremold July 23, 2024 14:20
Vremold
Vremold approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@Vremold Vremold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the effort.

@qingyunqu qingyunqu merged commit 21ad890 into llvm:main Jul 23, 2024
3 checks passed
pkapris-syrmia pushed a commit to pkapris-syrmia/torch-mlir that referenced this pull request Aug 15, 2024
@qingyunqu @pkapris-syrmia
[Torch] enhance fold of aten.slice.Tensor (llvm#3557)
c95671a 
so that it could support folding slice with any static shape.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vremold Vremold Vremold approved these changes

@rsuderman rsuderman Awaiting requested review from rsuderman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qingyunqu @Vremold