Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused variable warning from assertion variable #3512

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Fix unused variable warning from assertion variable #3512

merged 3 commits into from
Jun 28, 2024

Conversation

Max191
Copy link
Contributor

@Max191 Max191 commented Jun 28, 2024 •
edited
Loading

Inlines a variable into an assertion that is not used elsewhere to fix build warnings.

@Max191 Max191 requested a review from qedawkins June 28, 2024 14:38
qedawkins
qedawkins reviewed Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@qedawkins qedawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can put [[maybe_unused]] in front of the variable declaration instead, or just inline the getRank() to the assert.

@Max191 Max191 requested a review from qedawkins June 28, 2024 15:50
@Max191 Max191 merged commit a1c4089 into llvm:main Jun 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qedawkins qedawkins Awaiting requested review from qedawkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Max191 @qedawkins