Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Torch] fix toBuiltinTensor() #3415

Merged
merged 2 commits into from
Jun 8, 2024
Merged

[Torch] fix toBuiltinTensor() #3415

merged 2 commits into from
Jun 8, 2024

Conversation

qingyunqu
Copy link
Collaborator

  • Let toBuiltinTensor() reflects the original dtype of !torch.vtensor.
  • Backend handles dtype conversion themselves.

@qingyunqu qingyunqu requested a review from ramiro050 June 4, 2024 08:18
ramiro050
ramiro050 approved these changes Jun 8, 2024
View reviewed changes
Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long wait. LGTM, thanks!

@qingyunqu qingyunqu merged commit 689efc8 into llvm:main Jun 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramiro050 ramiro050 ramiro050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qingyunqu @ramiro050