Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract the Python APIs in the pt1 dir back to the root #3237

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

penguin-wwy
Copy link
Collaborator

No description provided.

@penguin-wwy penguin-wwy changed the title Extract common python code from the pt1 directory Extract the Python APIs in the pt1 dir back to the root Apr 26, 2024
@penguin-wwy
Copy link
Collaborator Author

Peel the Python APIs in the pt1 dir, which without dependency on the JitIR importer, back to the root python dir. Is this what you expected? @stellaraccident
#3205 (comment)

@stellaraccident
Copy link
Collaborator

Thanks. Will find some time to look at this in detail in the next bit (in the middle of some things this minute).

Copy link
Collaborator

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I know you were just moving code that you didn't write, but I gave it a once over and added a couple of comments. If you've got the time to make those updates, great, otherwise, it is fine.

python/torch_mlir/compiler_utils.py Outdated Show resolved Hide resolved
python/torch_mlir/compiler_utils.py Outdated Show resolved Hide resolved
@penguin-wwy penguin-wwy merged commit 944a6df into llvm:main Apr 27, 2024
3 checks passed
archana-ramalingam pushed a commit to archana-ramalingam/torch-mlir that referenced this pull request May 8, 2024
archana-ramalingam pushed a commit to archana-ramalingam/torch-mlir that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants