Added 2 Ops: Floor divide scalar and Floor divide scalar mode #3156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renxida
reviewed
Apr 15, 2024
rsuderman
requested changes
Apr 15, 2024
IanWood1
commented
Apr 15, 2024
|
made requested changes: use non-member functions and removed includes |
renxida
approved these changes
Apr 15, 2024
rsuderman
approved these changes
Apr 15, 2024
|
closes #3143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtenFloorDivideScalarOpAtenDivScalarModeOpfor the decomp.AtenDivScalarModeOpcreateDivModePayload()since the logic was nearly identical for bothAtenDivScalarModeOpandAtenDivTensorModeOp. Just a template functionAtenDivScalarModeOplowering for stablehloPytorch's
torch.floor_divide()in a previous version (for a reason unknown to me) preformed a truncation instead of "floor". The already implemented opAtenFloorDivideTensorOpwas done before this change. However, this wasn't caught because our testcases only tested positive floor division. I changed this to floor as well as adding a few test cases.