e2e support aten.linalg_norm to aten.linalg_vector_norm #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navahgar
reviewed
Feb 27, 2024
There was a problem hiding this comment.
LGTM. I will let @ramiro050 approve this to ensure this decomposition is okay.
ramiro050
requested changes
Feb 29, 2024
zezhang
force-pushed
the
zezhang/aten_linalg_norm
branch
from
56853f8 to
f881f41
Compare
|
@ramiro050 If you could take another look before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add e2d support for
aten.linalg_normby decompose it toaten.linalg_vector_norm.Lowering to
aten.linalg_matrix_normis still unsupported.To Test:
python -m e2e_testing.main -v