Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DecomposeComplexOps: update parseEquation to skip space char for AtenEinsumOp op #2910

Merged
merged 2 commits into from
Feb 15, 2024
Merged

DecomposeComplexOps: update parseEquation to skip space char for AtenEinsumOp op #2910

merged 2 commits into from
Feb 15, 2024

Conversation

zezhang
Copy link
Collaborator

@zezhang zezhang commented Feb 14, 2024 •
edited
Loading

Just a minor update to skip the space char if included in the equation string

@zezhang zezhang requested a review from navahgar February 15, 2024 00:15
navahgar
navahgar reviewed Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@navahgar navahgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM.

I see some other changes included in the PR under "Unchanged files with check annotations". Can you rebase with the latest on main?

@zezhang zezhang merged commit f3b38e5 into llvm:main Feb 15, 2024
3 checks passed
@zezhang zezhang deleted the zezhang/update_parsing branch February 15, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navahgar navahgar navahgar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zezhang @navahgar