Add clang-format check to CI #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See CI error for unformatted code: https://github.com/llvm/torch-mlir/actions/runs/7674955115/job/20920465785?pr=2816 |
|
I don't have much experience with Github actions, so let me know if I'm doing something terribly wrong 🙂 |
qedawkins
approved these changes
Jan 27, 2024
|
Over the weekend, I switched us off of buildAndTest (to ci.yml). I created a dedicated lint pipeline. Should be trivial to add there: https://github.com/llvm/torch-mlir/blob/main/.github/workflows/lint.yml |
ramiro050
force-pushed
the
clang-format
branch
13 times, most recently
from
44cae2a to
4561970
Compare
This PR adds a check to the CI right after checking out the Torch-MLIR repository to make sure that the changes in the PR don't require any `git clang-format` modifications.
ramiro050
force-pushed
the
clang-format
branch
from
4561970 to
b19e045
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to the CI right after checking out the Torch-MLIR repository to make sure that the changes in the PR don't require any
git clang-formatmodifications.