-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-organize project structure to separate PyTorch dependencies from core project. #2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellaraccident
force-pushed
the
pt2_phase1
branch
from
November 2, 2023 02:08
9fb5d56
to
b69107a
Compare
stellaraccident
force-pushed
the
pt2_phase1
branch
from
November 2, 2023 20:29
e2d1b15
to
823e051
Compare
powderluv
approved these changes
Nov 3, 2023
11 tasks
stellaraccident
pushed a commit
that referenced
this pull request
Nov 3, 2023
Updates Bazel build to mirror project reorganization from #2542. GHA: https://github.com/sjain-stanford/torch-mlir/actions/runs/6744430250/job/18334262852
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards the structure we discussed here: https://gist.github.com/stellaraccident/931b068aaf7fa56f34069426740ebf20
There are two primary goals:
projects/ltc
).Very little changes in this path with respect to build layering or options. These can be updated in a followup without commingling directory structure changes.
This also takes steps toward a couple of other layering enhancements:
It deviates from the discussed plan by having a
projects/
tree instead ofcompat/
. As I was thinking about it, this will better accommodate the follow-on code movement.Once things are roughly in place and the CI passing, followups will focus on more in-situ fixes and cleanups.