Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update AtenClampOp in torch-to-tosa to handle fp inputs #2516

Merged
merged 2 commits into from
Oct 17, 2023
Merged

update AtenClampOp in torch-to-tosa to handle fp inputs #2516

merged 2 commits into from
Oct 17, 2023

Conversation

zezhang
Copy link
Collaborator

@zezhang zezhang commented Oct 16, 2023

As titled.

@zezhang zezhang marked this pull request as ready for review October 16, 2023 23:17
@zezhang zezhang requested a review from navahgar October 16, 2023 23:17
navahgar
navahgar reviewed Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@navahgar navahgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

lib/Conversion/TorchToTosa/TorchToTosa.cpp Outdated Show resolved Hide resolved
@navahgar navahgar requested a review from sjarus October 17, 2023 01:11
@navahgar
Copy link
Collaborator

@sjarus Can you please review this?

@zezhang zezhang merged commit 4279b75 into llvm:main Oct 17, 2023
5 checks passed
@zezhang zezhang deleted the ze.zhang/tosa_clamp branch October 17, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navahgar navahgar navahgar left review comments

@sjarus sjarus sjarus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zezhang @navahgar @sjarus