Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aten.isclose support and its torch-to-tosa lowering #2512

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

zezhang
Copy link
Collaborator

@zezhang zezhang commented Oct 12, 2023

Add aten.isclose op
Add its torch-to-tosa lowering
Update the TorchToTosa/basic.mlir tests

To test e2e tosa lowering:
python -m e2e_testing.main -v -c=tosa

@zezhang zezhang marked this pull request as ready for review October 12, 2023 23:08
@zezhang zezhang requested a review from navahgar October 12, 2023 23:08
Copy link
Collaborator

@navahgar navahgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment inlined below.

Can you also add e2e test for this?

lib/Conversion/TorchToTosa/TorchToTosa.cpp Outdated Show resolved Hide resolved
@zezhang zezhang requested a review from navahgar October 13, 2023 00:26
Copy link
Collaborator

@navahgar navahgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@navahgar navahgar requested a review from ramiro050 October 13, 2023 18:03
@navahgar
Copy link
Collaborator

Requested a review from @ramiro050, in case he has any other comments.

Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, but other than that LGTM

@zezhang zezhang force-pushed the ze.zhang/aten_isclose branch from a18021e to a8fb81f Compare October 15, 2023 04:34
@zezhang zezhang merged commit f2c53b8 into llvm:main Oct 16, 2023
5 checks passed
@zezhang zezhang deleted the ze.zhang/aten_isclose branch October 16, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants