Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aten.unflatten.int support and its torch-to-tosa lowering #2509

Merged
merged 4 commits into from
Oct 14, 2023

Conversation

zezhang
Copy link
Collaborator

@zezhang zezhang commented Oct 10, 2023

Add aten.unflatten.int op
Add its torch-to-tosa lowering
Update the TorchToTosa/basic.mlir tests

To test e2e tosa lowering:

python -m e2e_testing.main -v -c=tosa

@zezhang zezhang marked this pull request as ready for review October 10, 2023 18:07
@zezhang zezhang requested a review from navahgar October 10, 2023 18:07
Copy link
Collaborator

@navahgar navahgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I only see a unit test for TorchToTosa. What about other tests? Any e2e tests expected to pass? Can you confirm that we are missing anything?

Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add an e2e test similar to the flatten ones:

class FlattenStaticModule(torch.nn.Module):

@zezhang
Copy link
Collaborator Author

zezhang commented Oct 12, 2023

Can you also add an e2e test similar to the flatten ones:

class FlattenStaticModule(torch.nn.Module):

Just added an e2e test. Note that the aten.unflatten.int op only has TOSA lowering for now, and the e2e test will fail on the Linalg-on-Tensors backend. @ramiro050 Please let me know if you think this is ok.

@zezhang zezhang requested a review from ramiro050 October 12, 2023 23:58
Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Other than a small change request, LGTM

python/torch_mlir_e2e_test/test_suite/basic.py Outdated Show resolved Hide resolved
@zezhang zezhang merged commit e649e06 into llvm:main Oct 14, 2023
5 checks passed
@zezhang zezhang deleted the ze.zhang/aten.unflatten.int branch October 14, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants