Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: reconcile differences between RollPyTorch and pre-merge checks #2482

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

ashay
Copy link
Collaborator

@ashay ashay commented Sep 23, 2023

The pre-merge checks that build PyTorch from source use an out-of-tree
build whereas, before this patch, the RollPyTorch workflow used an
in-tree build. This caused inconsistencies in the build output, so this
patch reconciles the differences.

The pre-merge checks that build PyTorch from source use an out-of-tree
build whereas, before this patch, the RollPyTorch workflow used an
in-tree build.  This caused inconsistencies in the build output, so this
patch reconciles the differences.
@ashay
Copy link
Collaborator Author

ashay commented Sep 23, 2023

Here is the most recent run.

@ashay ashay linked an issue Sep 23, 2023 that may be closed by this pull request
Copy link
Collaborator

@vivekkhandelwal1 vivekkhandelwal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashay for the fix.

@powderluv powderluv merged commit 5f772e8 into main Sep 23, 2023
@powderluv
Copy link
Collaborator

Thank you

@ashay ashay deleted the ashay/fix-roll-pytorch branch September 23, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with the Roll Pytorch CI
3 participants