Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Spot fixes related to nightly and stable PyTorch builds #2190

Merged
merged 2 commits into from
Jun 2, 2023
Merged

CI: Spot fixes related to nightly and stable PyTorch builds #2190

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a259724
CI: Skip (redundant) libtorch build when using stable PyTorch version
ashay Jun 2, 2023
89f8fb7
CI: Simplify guard conditions for creating and using libtorch cache
ashay Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/buildAndTest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ jobs:
llvm-build: out-of-tree
- os-arch: windows-x86_64
torch-version: stable
# For PyTorch stable builds, we don't build PyTorch from source
- torch-version: stable
torch-binary: OFF
include:
# Specify OS versions
- os-arch: ubuntu-x86_64
Expand Down Expand Up @@ -89,7 +92,7 @@ jobs:
arch: x64

- name: Try to Restore PyTorch Build Cache
if: matrix.os-arch != 'windows-x86_64'
if: ${{ matrix.torch-binary == 'OFF' }}
id: cache-pytorch
uses: actions/cache/restore@v3
with:
Expand Down Expand Up @@ -147,7 +150,7 @@ jobs:
run: ./build_tools/python_deploy/build_windows_ci.sh

- name: Save PyTorch Build Cache
if: ${{ github.ref_name == 'main' && matrix.torch-binary == 'OFF' && matrix.os-arch != 'windows-x86_64' }}
if: ${{ github.ref_name == 'main' && matrix.torch-binary == 'OFF' }}
uses: actions/cache/save@v3
with:
path: ${{ github.workspace }}/build_tools/python_deploy/wheelhouse
Expand Down