Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "update PyTorch version to 2.1.0.dev20230430" #2080

Merged
merged 1 commit into from
May 1, 2023

Conversation

ramiro050
Copy link
Collaborator

This reverts commit eab1930.

The PyTorch version does not yet exist for MacOS.

This reverts commit eab1930.

The PyTorch version does not yet exist for MacOS.
Copy link
Collaborator

@makslevental makslevental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just disable this thing? Or at least gate it by whether things successfully compile after the roll?

@powderluv
Copy link
Collaborator

yeah we should check for mac builds also before roll. @ashay should we just add the normal macos test ?

@ramiro050
Copy link
Collaborator Author

The MacOS build will take (from looking at the current pace) around 2 more hours to finish. However, this PR should pass all the builds, since this is reverting the latest commit on main and the previous commit is green. I will go ahead and merge early to unblock people.

@ramiro050 ramiro050 merged commit 55caaf6 into llvm:main May 1, 2023
@ramiro050 ramiro050 deleted the revert-roll branch May 1, 2023 22:58
@ashay
Copy link
Collaborator

ashay commented May 2, 2023

should we just add the normal macos test ?

Yes, this seems to be a recurring issue, so I'll add macOS to the list of tested platforms. I'll try to get this out this week.

gpetters94 pushed a commit to gpetters94/mlir-npcomp that referenced this pull request Jul 7, 2023
This reverts commit eab1930.

The PyTorch version does not yet exist for MacOS.
gpetters94 pushed a commit to gpetters94/mlir-npcomp that referenced this pull request Jul 7, 2023
This reverts commit eab1930.

The PyTorch version does not yet exist for MacOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants