Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e linalg support for aten.atan #2070

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Conversation

zezhang
Copy link
Collaborator

@zezhang zezhang commented Apr 27, 2023

As titled.

To test:

python -m e2e_testing.main -v
cmake --build build --target check-torch-mlir-all

@zezhang
Copy link
Collaborator Author

zezhang commented Apr 27, 2023

cc: @navahgar

@navahgar navahgar requested a review from ramiro050 April 27, 2023 20:58
Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you just update the PR title to something like "Add e2e linalg support for aten.atan", since this PR is doing more than just adding the ODS.

@zezhang zezhang changed the title Add ODS for aten.atan Add e2e linalg support for aten.atan Apr 28, 2023
@zezhang zezhang merged commit 7b73e0c into llvm:main Apr 28, 2023
@zezhang zezhang deleted the ze.zhang/atan_op branch April 28, 2023 07:05
gpetters94 pushed a commit to gpetters94/mlir-npcomp that referenced this pull request Jul 7, 2023
* new atan op

* update shape

---------

Co-authored-by: Ze Zhang <ze.zhang@getcruise.com>
gpetters94 pushed a commit to gpetters94/mlir-npcomp that referenced this pull request Jul 7, 2023
* new atan op

* update shape

---------

Co-authored-by: Ze Zhang <ze.zhang@getcruise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants