[Bazel] Add StableHLO registration dependency #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjain-stanford
changed the title
@mlir-hlo//stablehlo:register dep
sjain-stanford
changed the title
sjain-stanford
changed the title
sanjoy
approved these changes
Mar 15, 2023
gpetters94
pushed a commit
to gpetters94/mlir-npcomp
that referenced
this pull request
May 10, 2023
Fixes a broken bazel build from llvm#1887 causing the following build error: ``` ERROR: /root/.cache/bazel/_bazel_root/b89349c08f7224396763d14fe35cba11/external/torch-mlir/BUILD.bazel:819:10: Compiling tools/torch-mlir-opt/torch-mlir-opt.cpp failed: (Exit 1): clang failed: error executing command /usr/lib/llvm-16/bin/clang -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -Wunused-but-set-parameter -Wno-free-nonheap-object -fcolor-diagnostics -fno-omit-frame-pointer ... (remaining 366 arguments skipped) Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging external/torch-mlir/tools/torch-mlir-opt/torch-mlir-opt.cpp:16:10: fatal error: 'stablehlo/dialect/Register.h' file not found #include "stablehlo/dialect/Register.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Target @torch-mlir//:torch-mlir-opt failed to build ``` GHA workflow with the fix: https://github.com/sjain-stanford/torch-mlir/actions/runs/4421486154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a broken bazel build from #1887 causing the following build error:
GHA workflow with the fix:
https://github.com/sjain-stanford/torch-mlir/actions/runs/4421486154