build: update llvm tag to 3a020527 #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of changes: - Replace `llvm::None` with `std::nullopt`, since the former is deprecated (https://reviews.llvm.org/D139763) - Use setter for symbol visibility instead of passing string attribute when creating FuncOp
powderluv
approved these changes
Dec 14, 2022
|
Ok to land if tests pass and tree is green. But will let @silvasean take over if there is more work needed for the bump. |
|
Hey thanks for the fixes! I was on the rotation this week but thank you for taking over :) I will be on vacation over the weeks but I will need to do an extra rotation at some point to make up for this. |
|
No worries! It's too bad that the green commit wasn't ready to be published early like y'all had requested, so I figured I'd go ahead and do the LLVM bump as soon as the commit hash was known. |
|
Thank you |
PriyaBSavithiri
pushed a commit
to PriyaBSavithiri/mcw-torch-mlir
that referenced
this pull request
Dec 15, 2022
Summary of changes: - Replace `llvm::None` with `std::nullopt`, since the former is deprecated (https://reviews.llvm.org/D139763) - Use setter for symbol visibility instead of passing string attribute when creating FuncOp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Replace
llvm::Nonewithstd::nullopt, since the former is deprecated(https://reviews.llvm.org/D139763)
Use setter for symbol visibility instead of passing string attribute when
creating FuncOp
@powderluv @silvasean I am not sure if these changes are sufficient, since the ./build_tools/update_*.sh scripts fail at my end, but most of the lit and e2e tests pass. If the build fails, feel free to take over.