build: pin torchvision to latest nightly #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently pin the `torch` package to the latest nightly version, but since `torchvision` depends on the `torch` package, the pip resolver then has to run through an extensive list of `torchvision` packages that can be installed with the pinned `torch` package. This search fails in the RollPyTorch action, causing pip to settle on an old version of `torchvision` that does not work with our tests. In reality, we are only interested in a specific version of the `torchvision` package. To make the dependency explicit and to prevent test failures because of incorrect package installations, this patch makes two key changes: 1. `torchvision` is now pinned to the latest nightly release in pytorch-requirements.txt along with the version of `torch` that is necessary to install the requested `torchvision` package 2. The RollPyTorch action now looks for the latest `torchvision` package instead of the latest `torch` package before writing the version numbers for pinning in pytorch-requirements.txt
powderluv
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently pin the
torchpackage to the latest nightly version, butsince
torchvisiondepends on thetorchpackage, the pip resolverthen has to run through an extensive list of
torchvisionpackages thatcan be installed with the pinned
torchpackage. This search fails inthe RollPyTorch action, causing pip to settle on an old version of
torchvisionthat does not work with our tests. In reality, we areonly interested in a specific version of the
torchvisionpackage.To make the dependency explicit and to prevent test failures because of
incorrect package installations, this patch makes two key changes:
torchvisionis now pinned to the latest nightly release inpytorch-requirements.txt along with the version of
torchthat isnecessary to install the requested
torchvisionpackageThe RollPyTorch action now looks for the latest
torchvisionpackageinstead of the latest
torchpackage before writing the versionnumbers for pinning in pytorch-requirements.txt