Disable LTC and update PyTorch #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When built using PyTorch's master branch, the LTC code has been failing to build for a few days. As a result, the PyTorch version referenced by Torch-MLIR is stalled to the one from October 4th. In an effort to advance to PyTorch version, this patch disables LTC, and a subsequent patch will advance the PyTorch version.
|
@pashu123 It seems like after updating the PyTorch version, one of your tests fails because the oracle is slightly different from the computed result. Do you have a hunch as to why this might be the case? |
|
if required we can xfail to roll it forward with an issue tracker |
Also disables the `UpSampleNearest2dDynamicFactor_basic` e2e test, since the (PyTorch) oracle differs from the computed value for both the refbackend and the eager_mode backends.
|
Disabled the test for now, and noted it in this issue: #1473. |
powderluv
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
@antoniojkim We want to try and get tonights build successful. Happy to enable LTC again once it is fixed.
|
@pashu123 please re-enable the tests once it is fixed. |
|
Thanks, @ashay for filing it as an issue. I will take a look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When built using PyTorch's master branch, the LTC code has been failing
to build for a few days. As a result, the PyTorch version referenced by
Torch-MLIR is stalled to the one from October 4th.
This PR contains two patches: the first disables LTC and the second
advances the PyTorch version.