build: update ODS and shape library when updating PyTorch #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powderluv
approved these changes
Oct 2, 2022
|
Thank you for this. I think we were hitting some issues related to this downstream in SHARK. |
Updating the PyTorch version may break the Torch-MLIR build, as it did recently, since the PyTorch update caused the shape library to change, but the shape library was not updated in the commit for updating PyTorch. This patch introduces a new default-off environment variable to the build_linux_packages.sh script called `TM_UPDATE_ODS_AND_SHAPE_LIB` which instructs the script to run the update_torch_ods.sh and update_shape_lib.sh scripts. However, running these scripts requires an in-tree build and the tests that run for an in-tree build of Torch-MLIR are more comprehensive than those that run for an out-of-tree build, so this patch also swaps out the out-of-tree build for an in-tree build.
|
Rebased with main |
powderluv
approved these changes
Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the PyTorch version may break the Torch-MLIR build, as it did
recently, since the PyTorch update caused the shape library to change,
but the shape library was not updated in the commit for updating
PyTorch.
This patch introduces a new default-off environment variable to the
build_linux_packages.sh script called
TM_UPDATE_ODS_AND_SHAPE_LIBwhich instructs the script to run the update_torch_ods.sh and
update_shape_lib.sh scripts.
However, running these scripts requires an in-tree build and the tests
that run for an in-tree build of Torch-MLIR are more comprehensive than
those that run for an out-of-tree build, so this patch also swaps out
the out-of-tree build for an in-tree build.