Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: check exit code without causing script to fail #1447

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

ashay
Copy link
Collaborator

@ashay ashay commented Oct 2, 2022

A bug in the CI script caused the entire script to fail if the exit code
of the command for comparing with the existing hash returned a non-zero
exit status. The non-zero exit status for this comparison does not
imply failed execution, since it only indicates that the hash has
changed.


See fixed action here: https://github.com/llvm/torch-mlir/actions/runs/3168739550/jobs/5160152336

A bug in the CI script caused the entire script to fail if the exit code
of the command for comparing with the existing hash returned a non-zero
exit status.  The non-zero exit status for this comparison does not
imply failed execution, since it only indicates that the hash has
changed.
@ashay ashay requested a review from powderluv October 2, 2022 13:25
@ashay ashay merged commit 005d40f into main Oct 2, 2022
@ashay ashay deleted the ashay/fix-exit-code-check branch October 2, 2022 21:04
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
* generated ERRNO and added exception code in test examples
Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant