Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable libzstd detection to fix M1 builds #1380

Merged
merged 1 commit into from
Sep 18, 2022
Merged

Conversation

powderluv
Copy link
Collaborator

Previously we sudo rm -f the non-universal zstd installed in the GHA. The CI has this fix but it doesn't take effect in the Release builds without this change.

Previously we `sudo rm -f` the non-universal zstd installed in the GHA. The CI has this fix but it doesn't take effect in the Release builds without this change.
Copy link
Collaborator

@makslevental makslevental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@powderluv powderluv merged commit 45edef3 into main Sep 18, 2022
@powderluv powderluv deleted the powderluv-fix-m1-builds branch September 18, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants