Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symint ops and blacklist lift_fresh_copy #1373

Merged
merged 3 commits into from
Sep 20, 2022

Conversation

antoniojkim
Copy link
Collaborator

@antoniojkim antoniojkim commented Sep 15, 2022

Fix LTC issues caused by changes in upstream PyTorch

  • A new symint key was added to the native functions yaml
  • The lift_fresh_copy op was blacklisted in LTC as it is not yet supported

This PR depends on this upstream PR getting in first: pytorch/pytorch#85029

Issue: #1364

@antoniojkim antoniojkim self-assigned this Sep 15, 2022
@antoniojkim antoniojkim force-pushed the antoniojkim/fix_empty_symint branch from 7efacc0 to a5ab3f2 Compare September 19, 2022 13:20
@antoniojkim antoniojkim marked this pull request as ready for review September 19, 2022 13:21
@antoniojkim antoniojkim force-pushed the antoniojkim/fix_empty_symint branch from a5ab3f2 to a5f1752 Compare September 19, 2022 15:15
Copy link
Contributor

@silvasean silvasean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this fixed!!

@antoniojkim antoniojkim merged commit 8967463 into llvm:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants