Implement Expand/Collapse Functionality for Aten.View (Re-Opened_ #1353
Conversation
JakopinA
force-pushed
the
jakopina-view2
branch
from
09a8ff4 to
1149333
Compare
JakopinA
force-pushed
the
jakopina-view2
branch
from
1149333 to
146ea0e
Compare
|
What is the relationship between this PR and #1357 -- Are they independent? cc @gpetters94 |
JakopinA
force-pushed
the
jakopina-view2
branch
2 times, most recently
from
7a9e1f9 to
5602c25
Compare
I've reached out to him to try to figure something out. I will say that this commit has support for inferring a dynamic dim along with a couple of unit tests, so it should be as ready to go as I could get it. |
|
I added a comment on #1357, but I believe this is the correct approach to the view cases that are neither expand nor collapse. It would be much clearer with unit tests and/or samples for what the IR looks like with each PR though. Dynamic support for [x, y] -> [y, x] is still blocked by tensor.expand_shape in this PR as well. This is also shown in #1390. |
JakopinA
force-pushed
the
jakopina-view2
branch
5 times, most recently
from
4376d2f to
0a733f4
Compare
|
@silvasean Anything here you need me to do? Everything should be working now. |
JakopinA
force-pushed
the
jakopina-view2
branch
4 times, most recently
from
7150ddd to
1e785eb
Compare
|
Alright, I've removed a lot of the redundant e2e tests and added two more important unit tests. Should be good to go! |
JakopinA
force-pushed
the
jakopina-view2
branch
from
1e785eb to
7a9669b
Compare
JakopinA
force-pushed
the
jakopina-view2
branch
from
7a9669b to
d002977
Compare
JakopinA
force-pushed
the
jakopina-view2
branch
from
d002977 to
b2ffc12
Compare
Second PR for this functionality after being opened with #1309 and closed with #1347 . Issues raised were with the exclusive use of static sizes and lack of unit tests.