Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update llvm tag to 00d648bd #1307

Merged
merged 1 commit into from
Aug 30, 2022
Merged

build: update llvm tag to 00d648bd #1307

merged 1 commit into from
Aug 30, 2022

Conversation

ashay
Copy link
Collaborator

@ashay ashay commented Aug 29, 2022

@ashay
Copy link
Collaborator Author

ashay commented Aug 29, 2022

@Vremold @fortianyou @ZihengJiang Could you help me diagnose the MHLO end-to-end test failures please? The failure seems similar to the one observed in the last LLVM update [https://github.com//pull/1268].

@tanyokwok
Copy link
Collaborator

@ashay I believe this is a bug of MHLO legalization to LinAlg. The error raised here legalize_to_linalg.cc#L2031, because reversals has no value.

@ashay
Copy link
Collaborator Author

ashay commented Aug 30, 2022

Thanks @fortianyou!

Do you know if this bug is being tracked / debugged upstream? I am tempted to disable this test until the underlying bug is fixed and it'd be nice to include a link to the tracking bug.

I fixed the problem in the greencommit branch and created an upstream PR here: tensorflow/tensorflow#57530.

 - Update MHLO commit to build with LLVM commit hash 00d648b
 - Update TorchToMhlo code to work with Stablehlo
 - Re-enabled two failing TOSA tests, thus resolving Github Issue #1231
@ashay ashay requested review from silvasean and powderluv August 30, 2022 19:13
Copy link
Contributor

@silvasean silvasean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ashay ashay merged commit e52e886 into llvm:main Aug 30, 2022
@ashay ashay deleted the ashay/update-llvm-tag branch August 30, 2022 19:44
AmosLewis pushed a commit to AmosLewis/torch-mlir that referenced this pull request Sep 2, 2022
 - Update MHLO commit to build with LLVM commit hash 00d648b
 - Update TorchToMhlo code to work with Stablehlo
 - Re-enabled two failing TOSA tests, thus resolving Github Issue llvm#1231
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
* Export some functions on Windows

Signed-off-by: Tung D. Le <tungld@gmail.com>

* Remove .def files for end-to-end tests

Signed-off-by: Tung D. Le <tungld@gmail.com>

* No .def files when linking

Signed-off-by: Tung D. Le <tungld@gmail.com>

* Print out exported funcs

Signed-off-by: Tung D. Le <tungld@gmail.com>

* Check windows in triple

Signed-off-by: Tung D. Le <tungld@gmail.com>

* Test lit tests

Signed-off-by: Tung D. Le <tungld@gmail.com>

* Export functions in the cruntime lib

Signed-off-by: Tung D. Le <tungld@gmail.com>

* Use triple to detect Windows OS

Signed-off-by: Tung D. Le <tungld@gmail.com>

* Use a separate macro

Signed-off-by: Tung D. Le <tungld@gmail.com>

* Use defined(_WIN32)

Signed-off-by: Tung D. Le <tungld@gmail.com>

* Use defined(_WIN32)

Signed-off-by: Tung D. Le <tungld@gmail.com>

* Install headers for cruntime

Signed-off-by: Tung D. Le <tungld@gmail.com>

* Add preserveLLVMIR option and reorganie CompilerUtils

Signed-off-by: Tung D. Le <tungld@gmail.com>

* clang-format

Signed-off-by: Tung D. Le <tungld@gmail.com>

* Support multiple entries and add lit tests

Signed-off-by: Tung D. Le <tungld@gmail.com>

* Minor change

Signed-off-by: Tung D. Le <tungld@gmail.com>

* Fix conditions

Signed-off-by: Tung D. Le <tungld@gmail.com>

* undo

Signed-off-by: Tung D. Le <tungld@gmail.com>

* Missing change when merging

Signed-off-by: Tung D. Le <tungld@gmail.com>

* More missing changes when merging

Signed-off-by: Tung D. Le <tungld@gmail.com>

Co-authored-by: Ettore Tiotto <etiotto@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants