-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MHLO] Init MHLO pooling-like op conversion #1141
[MHLO] Init MHLO pooling-like op conversion #1141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you help remove the "*Op" suffix in the file names to align with TorchToLinalg convention?
Could you also add the file into the bazel build like this? #1148 |
94deb25
to
746fe65
Compare
Co-authored-by: Bairen Yi <yibairen.byron@bytedance.com> Co-authored-by: Jiawei Wu <xremold@gmail.com> Co-authored-by: Tianyou Guo tianyou.gty@alibaba-inc.com Co-authored-by: Xu Yan <yancey.yx@alibaba-inc.com> Co-authored-by: Ziheng Jiang <ziheng.jiang@bytedance.com>
746fe65
to
73ce7d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* compiled without type Signed-off-by: Tong Chen <chentong@us.ibm.com> * change ONNXOpsDialect to ONNXDialect Signed-off-by: Tong Chen <chentong@us.ibm.com> * new CMAKE Signed-off-by: Tong Chen <chentong@us.ibm.com> * first step to add type Signed-off-by: Tong Chen <chentong@us.ibm.com> * ONNXOps.td compiled with type Signed-off-by: Tong Chen <chentong@us.ibm.com> * refine CMake Signed-off-by: Tong Chen <chentong@us.ibm.com> * compiled with stringtype conflict Signed-off-by: Tong Chen <chentong@us.ibm.com> * chang StringType and pass lit test Signed-off-by: Tong Chen <chentong@us.ibm.com> * cleanup Signed-off-by: Tong Chen <chentong@us.ibm.com> * format Signed-off-by: Tong Chen <chentong@us.ibm.com> * change MLIR.cmake Signed-off-by: Tong Chen <chentong@us.ibm.com> * split files Signed-off-by: Tong Chen <chentong@us.ibm.com> * fix Signed-off-by: Tong Chen <chentong@us.ibm.com> * format Signed-off-by: Tong Chen <chentong@us.ibm.com> * fix cmake Signed-off-by: Tong Chen <chentong@us.ibm.com> * comments Signed-off-by: Tong Chen <chentong@us.ibm.com> * line length Signed-off-by: Tong Chen <chentong@us.ibm.com> * typo Signed-off-by: Tong Chen <chentong@us.ibm.com> * cmake order Signed-off-by: Tong Chen <chentong@us.ibm.com> * change for new llvm Signed-off-by: Tong Chen <chentong@us.ibm.com>
See RFC #999
Co-authored-by: Bairen Yi yibairen.byron@bytedance.com
Co-authored-by: Jiawei Wu xremold@gmail.com
Co-authored-by: Tianyou Guo tianyou.gty@alibaba-inc.com
Co-authored-by: Xu Yan yancey.yx@alibaba-inc.com
Co-authored-by: Ziheng Jiang ziheng.jiang@bytedance.com